Add Graph.merge/2 for combining two graphs#89
Open
dannote wants to merge 1 commit intobitwalker:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's currently no way to combine two graphs without iterating over all vertices and edges of one and adding them to the other via the public API. This is both verbose and slow — each
add_edgecall does hash lookups and MapSet insertions individually.Graph.merge/2combines all vertices and edges from two graphs in a single operation by merging the underlying maps directly. This is useful when building a graph in parts (e.g. analyzing separate modules and combining the results, or merging independently constructed subgraphs into a whole).When the same edge exists in both graphs (same vertex pair and label), the weight from the second graph wins — consistent with
Map.merge/2semantics. Same goes for vertex labels. Both graphs must be of the same type, otherwise anArgumentErroris raised.